[Deprecate] Deprecate pooling multi task support.#37956

Merged

noooop merged 17 commits intovllm-project:mainfrom

noooop:deprecate_multi_task

Mar 24, 2026

Collaborator

noooop commented Mar 24, 2026 •

edited

Loading

Purpose

Following #37537 #37632

Pooling multitask support is deprecated and will be removed in v0.20.

When the default pooling task is not what you want, you need to manually specify it via PoolerConfig(task=<task>) offline or --pooler-config.task <task> online.

Remove pooling multi task support. #37861

Test Plan

keep ci green

Test Result

Essential Elements of an Effective PR Description Checklist

The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
The test plan, such as providing test command.
The test results, such as pasting the results comparison before and after, or e2e results
(Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
(Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

noooop added 2 commits

March 24, 2026 11:14


          init

709dde1

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>


          + test

b09002f

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>

Contributor

mergify bot commented Mar 24, 2026

Documentation preview: https://vllm--37956.org.readthedocs.build/en/37956/

mergify bot added documentation frontend labels

gemini-code-assist bot reviewed

View reviewed changes

Contributor

gemini-code-assist bot left a comment

Code Review

This pull request effectively deprecates multi-task support for pooling models, encouraging users to specify a single task. The changes are well-structured, with logic centralized in ModelConfig.get_pooling_task and LLM._verify_pooling_task. The documentation and tests have been updated accordingly to reflect this deprecation. I've found one issue in a test case that needs to be addressed.

tests/entrypoints/pooling/embed/test_offline.py Outdated

noooop mentioned this pull request

[Frontend] Remove pooling multi task support. (Hold off until v0.20.0) #37861

Draft

5 tasks


          Update tests/entrypoints/pooling/embed/test_offline.py

b166500

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: wang.yuqi <noooop@126.com>

Collaborator Author

noooop commented Mar 24, 2026

/gemini review

noooop marked this pull request as ready for review

March 24, 2026 03:33

noooop requested review from DarkLight1337, ProExpertProg, WoosukKwon, hmellor, houseroad, mgoin, robertgshaw2-redhat, tlrmchlsmth, yewentao256 and youkaichao as code owners

March 24, 2026 03:33

gemini-code-assist bot reviewed

View reviewed changes

Contributor

gemini-code-assist bot left a comment

Code Review

This pull request deprecates multi-task support for pooling models, introducing a default pooling task for each model and issuing a warning when a non-default task is used. The changes are well-structured, with updates to configuration, entrypoints, tests, and documentation to reflect this deprecation. The refactoring to centralize task verification logic in _verify_pooling_task is a good improvement. I've found a couple of issues with incorrect error messages that could mislead users, for which I've left specific comments.

vllm/entrypoints/llm.py

vllm/entrypoints/pooling/pooling/serving.py

noooop and others added 2 commits

March 24, 2026 11:36


          Update vllm/entrypoints/llm.py

765508a

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: wang.yuqi <noooop@126.com>


          Update vllm/entrypoints/pooling/pooling/serving.py

aa986ce

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: wang.yuqi <noooop@126.com>

Collaborator Author

noooop commented Mar 24, 2026

cc @DarkLight1337

Ready for review

DarkLight1337 reviewed

View reviewed changes

docs/models/pooling_models/README.md Outdated

noooop added 2 commits

March 24, 2026 11:52


          refine

c25f79f

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>


          pooling_task -> task

ec86cac

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>

DarkLight1337 reviewed

View reviewed changes

docs/models/pooling_models/README.md Outdated

noooop and others added 2 commits

March 24, 2026 13:49


          Update docs/models/pooling_models/README.md

37efc43

Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: wang.yuqi <noooop@126.com>


          refine

8f72b59

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>

vllm-project deleted a comment from mergify bot


          fix test

a541644

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>

noooop added the ready label

noooop commented

View reviewed changes

tests/entrypoints/pooling/classify/test_offline.py

noooop removed the ready label

noooop added 2 commits

March 24, 2026 17:51


          update tests

a5f5a14

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>


          Merge branch 'main' into deprecate_multi_task

eb78729

noooop commented

View reviewed changes

tests/entrypoints/pooling/token_classify/test_online.py

noooop commented

View reviewed changes

vllm/entrypoints/llm.py

DarkLight1337 approved these changes

View reviewed changes


          Merge branch 'main' into deprecate_multi_task

cd5426e

noooop enabled auto-merge (squash)

March 24, 2026 12:41

github-actions bot added the ready label

noooop merged commit 1b6cb92 into vllm-project:main

57 checks passed

noooop deleted the deprecate_multi_task branch

March 24, 2026 14:30

RhizoNymph pushed a commit to RhizoNymph/vllm that referenced this pull request


          [Deprecate] Deprecate pooling multi task support. (vllm-project#37956)

17624b7

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>

HenryTangDev pushed a commit to HenryTangMain/vllm that referenced this pull request


          [Deprecate] Deprecate pooling multi task support. (vllm-project#37956)

eb8750f

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>

malaiwah pushed a commit to malaiwah/vllm that referenced this pull request


          [Deprecate] Deprecate pooling multi task support. (vllm-project#37956)

040eddb

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: Michel Belleau <michel.belleau@malaiwah.com>

khairulkabir1661 pushed a commit to khairulkabir1661/vllm that referenced this pull request


          [Deprecate] Deprecate pooling multi task support. (vllm-project#37956)

5d57802

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>

Monishver11 pushed a commit to Monishver11/vllm that referenced this pull request


          [Deprecate] Deprecate pooling multi task support. (vllm-project#37956)

03c81bb

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>

nithinvc pushed a commit to nithinvc/vllm that referenced this pull request


          [Deprecate] Deprecate pooling multi task support. (vllm-project#37956)

a0de2d3

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>

Signed-off-by: Nithin Chalapathi <nithin.ch10@gmail.com>

JiantaoXu pushed a commit to JiantaoXu/vllm that referenced this pull request


          [Deprecate] Deprecate pooling multi task support. (vllm-project#37956)

c32d4e7

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>

vrdn-23 pushed a commit to vrdn-23/vllm that referenced this pull request


          [Deprecate] Deprecate pooling multi task support. (vllm-project#37956)

ae08165

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: Vinay Damodaran <vrdn@hey.com>

EricccYang pushed a commit to EricccYang/vllm that referenced this pull request


          [Deprecate] Deprecate pooling multi task support. (vllm-project#37956)

dec5bbb

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: EricccYang <yangyang4991@gmail.com>

bhargav-patel-29 pushed a commit to Bharatgen-Tech/vllm that referenced this pull request


          [Deprecate] Deprecate pooling multi task support. (vllm-project#37956)

549972a

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: bhargav-patel-29 <bhargav.patel@tihiitb.org>

liuchenbing2026 pushed a commit to liuchenbing2026/vllm that referenced this pull request


          [Deprecate] Deprecate pooling multi task support. (vllm-project#37956)

3238cd4

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>

rishitdholakia13 pushed a commit to rishitdholakia13/vllm that referenced this pull request


          [Deprecate] Deprecate pooling multi task support. (vllm-project#37956)

90a9fc8

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: rishitdholakia13 <rishit+github@cohere.com>

puririshi98 pushed a commit to puririshi98/vllm that referenced this pull request


          [Deprecate] Deprecate pooling multi task support. (vllm-project#37956)

c689cd2

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: Rishi Puri <riship@nvidia.com>

big-yellow-duck pushed a commit to EmbeddedLLM/vllm that referenced this pull request


          [Deprecate] Deprecate pooling multi task support. (vllm-project#37956)

fe72e27

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>

mtparet pushed a commit to blackfuel-ai/vllm that referenced this pull request


          [Deprecate] Deprecate pooling multi task support. (vllm-project#37956)

fdf8824

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DarkLight1337 DarkLight1337 approved these changes

WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

youkaichao Awaiting requested review from youkaichao youkaichao is a code owner

robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

mgoin Awaiting requested review from mgoin mgoin is a code owner

tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

houseroad Awaiting requested review from houseroad houseroad is a code owner

hmellor Awaiting requested review from hmellor hmellor is a code owner

yewentao256 Awaiting requested review from yewentao256 yewentao256 is a code owner

ProExpertProg Awaiting requested review from ProExpertProg ProExpertProg is a code owner

+1 more reviewer

gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Labels

documentation frontend ready